Add stash support feature #4885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lack of update for db schema example for logs and new line from your code if (!player) {
//std::cout << "Error: Player not found for ID: " << playerId << std::endl;
return;
} // << LACK OF NEW LINE THERE
if (!player->isPremium()) {
//std::cout << "Error: Player does not have a premium account." << std::endl;
player->sendCancelMessage(RETURNVALUE_YOUNEEDPREMIUMACCOUNT);
return;
} |
|
So far, is working as intended (you require some client source modifications that I can also provide) |
what about Cipsoft client? |
|
I don't know the protocols and parse/send functions they use for it. But should be easy to tackle. It works with otcv8 with source edits. |
|
So you implemented it but it doesnt work with either the cip client or otclient? |
Thank you for your comment! Let me clarify:
As this is a work-in-progress feature, the intention is to establish the groundwork for a stash system and invite collaboration to fully implement and refine it. Contributions to make it fully functional (especially for client-side integration) are very welcome! Let’s work together to make this feature robust and compatible for all users. |
|
Windows build is not working Errors |
ArturKnopik
requested changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This pull request introduces initial source code changes to establish the base for a new "stash" system in The Forgotten Server. The stash system aims to provide players with a dedicated storage feature for better inventory organization and long-term item management.
Current Status
The current implementation focuses on laying the groundwork in the source code. It is not yet fully functional or integrated into the game mechanics. This pull request is being shared to invite collaboration from the community to:
Key Changes in the Source Code
player.cpp,luascript.cpp, etc.) to support the concept of stashing items.Issues Addressed
This pull request does not address a specific issue but is an effort to introduce a new feature collaboratively.
How to Test
Call for Collaboration
I am seeking feedback and contributions from the community to complete this feature. Specifically, help is welcome for:
Let’s build this feature together!