Patch bonus

[tofutim]

@oysteinkrog I re-forked your project, so here is a consolidated pull request. It is a separate thought, but I wonder if you should rename this project to PCLSQLite, to go with PCLCrypto and PCLStorage, etc.

This fat PR contains:

• dynamic Query, for lazy people who just want to "SELECT * FROM ..." with no predetermined type or mapping
• remove Platform.WindowsPhoneApp81 which is not even used in nuget
• switch Platform.WinRT to portable library covering Win8.1 and WP8.1
• added tests for WinRT.Phone and UWP (based on Platform.WinRT)
• added ability to have multiple queries in same CommandText, separated by ';', added tests
• added named binding support, still need to add test
• fix StressTest by using 'wal' and adding _locker to PreparedSQLiteInsertCommand and Task.Factory.CreateNew -> Task.Run
• consolidate common test code and platform code into Shared Projects
• fix broken CallsOnUnsupportedTypes as DateTimeOffset is now supported, use DivideByZeroException and Newtonsoft.Json serializer
• get appveyor to work!

[tofutim]

apparently dynamic is not supported in Android and iOS, so I need to back that out.

[tofutim]

I probably should switch the appveyor back to OSS for now, but it fails on a couple of the platform builds and never gets to the tests. There is an issue compiling Android and complains about two mscorlibs, however, it is an issue with Xamarin needing an update on appveyor.

[oysteinkrog]

This is really good work, but it's very messy :P
I'm going to go through it and clean up the commits a bit.
It's really awesome that we now have appveyor w/tests running, thank you so much:)

[oysteinkrog]

The generic platform is meant to use any local sqlite3 libraries available on the platform, adding binaries for appveyor goes against the purpose of it. An alternative might be to use appveyor to install sqlite before the tests are run.
I'm going to just make appveyor run the Win32 tests (as that platform nuget includes the necessary sqlite binaries).

[oysteinkrog]

I am not sure I want to merge the shared project stuff, as it feels like a move back to #define-based code (which I really don't like).
The multiquery stuff is nice I think, but needs a separate PR.

[tofutim]

The shared project stuff is actually not so bad if you look at it. There is
almost no defined codes if you drop Windows Phone 8.

On Sat, Nov 14, 2015 at 4:25 AM, Øystein Krog [email protected]
wrote:

I am not sure I want to merge the shared project stuff, as it feels like a
move back to #define-based code (which I really don't like).
The multiquery stuff is nice I think, but needs a separate PR.

—
Reply to this email directly or view it on GitHub
#252 (comment)
.

[tofutim]

To do the multi-query stuff, you have to copy and paste the same change for
each Platform. It is madness.

If you look at the shared code, there are only a handful of #if defines.
And I think some of those don't even have to be there. I think you can
close and initialize in WinRT

On Sat, Nov 14, 2015 at 8:27 AM, Tim Uy [email protected] wrote:

The shared project stuff is actually not so bad if you look at it. There
is almost no defined codes if you drop Windows Phone 8.

On Sat, Nov 14, 2015 at 4:25 AM, Øystein Krog [email protected]
wrote:

I am not sure I want to merge the shared project stuff, as it feels like
a move back to #define-based code (which I really don't like).
The multiquery stuff is nice I think, but needs a separate PR.

—
Reply to this email directly or view it on GitHub
#252 (comment)
.