Fix usage of array types in DSL #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done by hacking `arrayParameterMetaData` - Add test to discover which array types work well with DSL for now. - Results were somewhat disappointing, because the mechanism for forwarding postgres type names for arrays is not good enough. - It's hard to fix this optimally, because we can't change library typeclasses - Add a hack to `arrayParameterMetaData` which computes `ParameterMetadata` for array types. this makes the test mostly green. - An issue we need more wrapper types to solve is that in postgres, arrays of `varchar` and `text` are not comparable!
- replace `ParameterMetaData` (ported from anorm) with a correctly defined `PGType` type class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
varcharandtextare not comparable!This PR goes some way towards fixing the most dire things, but it was a mistake to reuse sql type names from the typeclass instances of the database libraries.
The fix for anorm is a hack, and the only path foward is really to not use
ParameterMetaDataat all.