Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #92

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Refactor #92

wants to merge 8 commits into from

Conversation

p0rtL6
Copy link

@p0rtL6 p0rtL6 commented Jan 6, 2025

Refactor

This is a collection of refactoring updates to improve code quality, standardize formatting, and overhaul lacking features. If anything here should be changed, reverted, or updated to merge, I am more than happy to make those changes as requested.

The major changes are as follows:

  • Split task preparation into separate files (prepare.py, execute.py)
  • Removed the copied and pasted code between modes, instead opting for passing the mode as an argument
  • Removed the copied and pasted code for parsing responses into enums, opting to put it in a method on the enum
  • Refactored the entire reporter class, added the "--disable-escape-codes" option to fix output for terminals that do not support or enable ANSI escape codes
  • Standardized all terminal output to use the refactored reporter class, including underlying Responder code
  • Properly enabled and standardized verbose and debug output
  • Added proper file logging using the refactored reporter class

Please also see: Windows Support Discussion

@p0dalirius p0dalirius self-assigned this Jan 7, 2025
@p0dalirius p0dalirius added the enhancement New feature or request label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants