Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization direct from proxy #35

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sneakers-the-rat
Copy link
Collaborator

Problem: sometimes pydantic loses the NDArray annotation and needs to be able to serialize directly from proxy objects, eg. when used as an Extra annotation or otherwise.

This PR ensures that all proxy objects can also roundtrip directly

@sneakers-the-rat sneakers-the-rat force-pushed the serialization-direct-from-proxy branch from 885de95 to 421b2e2 Compare October 18, 2024 05:02
@coveralls
Copy link

coveralls commented Oct 18, 2024

Pull Request Test Coverage Report for Build 11414136288

Details

  • 47 of 51 (92.16%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.447%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/numpydantic/interface/numpy.py 14 15 93.33%
src/numpydantic/serialization.py 12 13 92.31%
src/numpydantic/interface/hdf5.py 9 11 81.82%
Totals Coverage Status
Change from base Build 11289927938: 0.1%
Covered Lines: 1521
Relevant Lines: 1545

💛 - Coveralls

@sneakers-the-rat sneakers-the-rat marked this pull request as ready for review October 19, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants