Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip channel checks #173

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add option to skip channel checks #173

merged 1 commit into from
Nov 15, 2023

Conversation

benthecarman
Copy link
Contributor

There are a bunch of extra checks that are done for channels but if you aren't using channels would be nice to skip them

Tibo-lg
Tibo-lg approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Tibo-lg Tibo-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so my plan is to refactor the Manager and extract a ChannelManager so that people who don't care about channels don't have not only this, but also the channel related interfaces. But if that helps you in the mean time I'm ok with skipping the checks.

@Tibo-lg Tibo-lg merged commit 5b5da81 into p2pderivatives:master Nov 15, 2023
54 checks passed
@benthecarman benthecarman deleted the skip-channel-checks branch November 15, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tibo-lg Tibo-lg Tibo-lg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benthecarman @Tibo-lg