return counterparty pk when rejecting subchannel offer and handle rejected state #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful because we will need to send the reject message afterwards and for that we need the key.
holzeis
approved these changes
Dec 4, 2023
bonomat
changed the title
Tibo-lg
requested changes
Dec 5, 2023
bonomat
force-pushed
the
chore/reject_sub_channel_close_offer-return-value
branch
from
81ac40c to
e3c3602
Compare
I've added a test https://github.com/p2pderivatives/rust-dlc/compare/81ac40c551203a18be147feca7e4361d02ef2567..e3c3602bdd6d32fd00dbff2577671269ab61cb50 |
Tibo-lg
reviewed
Dec 11, 2023
|
|
||
| reject_offer(&test_params); | ||
|
|
||
| offer_sub_channel_internal(&test_params, false); |
There was a problem hiding this comment.
nit: can you use open_sub_channel instead since it's there?
|
I'll squash the last two commits before merged once approved |
We need to treat the SubChannelState::Rejected same as `OffChainClosed` as otherwise we won't be able to open a new subchannel if an offer was rejected.
bonomat
force-pushed
the
chore/reject_sub_channel_close_offer-return-value
branch
from
5f80d38 to
994864a
Compare
bonomat
deleted the
chore/reject_sub_channel_close_offer-return-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful because we will need to send the reject message afterwards and for that we need to know to whom.