WIP: stateless keys #187
Closed
WIP: stateless keys #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
stateless-keys
branch
from
f146635 to
8cedb4a
Compare
benthecarman
force-pushed
the
stateless-keys
branch
from
8cedb4a to
06cd710
Compare
Tibo-lg
reviewed
Dec 8, 2023
There was a problem hiding this comment.
I took a quick look and my feeling is that I'd rather not have the compute_secret_key within the library and leave that responsibility to the user. I like the LDK approach of having a SignerProvider that creates a Signer per channel (in this case it would be per contract).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185
Didn't implement fully for channels yet, want to see if this passes CI and thoughts on the design