Fix/sample oracle and peer connection #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibo-lg
force-pushed
the
fix/sample-oracle-and-peer-connection
branch
2 times, most recently
from
f103560 to
2ed0443
Compare
Tibo-lg
force-pushed
the
fix/sample-oracle-and-peer-connection
branch
from
2ed0443 to
51734dd
Compare
luckysori
approved these changes
Feb 22, 2024
sample/Readme.md
Outdated
| @@ -21,6 +21,8 @@ In a different terminal: | |||
| cargo run ./examples/configurations/bob.yml | |||
| ``` | |||
|
|
|||
| Update the [example contract](./examples/contracts/numerical_contract_input.json#L82) replacing the number after `btcusd` with a unix timestamp sometimes in the future (this will correspond to the contract maturity date). | |||
There was a problem hiding this comment.
Suggested change
| Update the [example contract](./examples/contracts/numerical_contract_input.json#L82) replacing the number after `btcusd` with a unix timestamp sometimes in the future (this will correspond to the contract maturity date). | |
| Update the [example contract](./examples/contracts/numerical_contract_input.json#L82) replacing the number after `btcusd` with a unix timestamp some time in the future (this will correspond to the contract maturity date). |
Comment on lines
+132
to
+135
| println!( | ||
| "Node public key: {}", | ||
| km.get_node_id(lightning::sign::Recipient::Node).unwrap() | ||
| ); |
There was a problem hiding this comment.
Oh yeah, this is that sneaky bug fix you mentioned a while ago.
There was a problem hiding this comment.
Yeah, wasted way to much time on that...
Tibo-lg
force-pushed
the
fix/sample-oracle-and-peer-connection
branch
from
51734dd to
95f2f12
Compare
Hopefully the test should make sure it's working :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192
Also added a small test for the sample to avoid that it silently breaks.
@kevkevinpal if by any chance you have time to give it a try it'd be nice to have your feedback to make sure it's working for you.