Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes of types for working benchmarks #214

Merged

Conversation

alfonzii
Copy link
Contributor

@alfonzii alfonzii commented May 6, 2024

Benchmarks were not working straight away, probably, because last commit was 2 years old. I tried to tinker with code, and found out, there were new types already in codebase. I changed them accordingly in benchmarks to make them work again.

Copy link
Contributor

@Tibo-lg Tibo-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some tiny nits otherwise LGTM.

dlc/benches/benchmarks.rs Outdated Show resolved Hide resolved
dlc/benches/benchmarks.rs Outdated Show resolved Hide resolved
@Tibo-lg Tibo-lg merged commit 240c274 into p2pderivatives:master May 7, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants