Port back changes from lightning experiment branch #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibo-lg
force-pushed
the
chore/port-back-lightning-changes
branch
2 times, most recently
from
84ce95b to
a280669
Compare
luckysori
reviewed
Jul 10, 2024
Comment on lines
-22
to
-24
| watched_tx: HashMap<Txid, ChannelInfo>, | ||
| pub(crate) watched_tx: HashMap<Txid, WatchState>, | ||
| pub(crate) watched_txo: HashMap<OutPoint, WatchState>, | ||
| pub(crate) last_height: u64, | ||
| pub(crate) last_block_hashes: Vec<BlockHash>, |
There was a problem hiding this comment.
A reminder that this is a breaking change in case you want to communicate it somehow.
There was a problem hiding this comment.
I guess there are a bunch of breaking changes with this PR anyway.
Comment on lines
+126
to
+131
| /// Check if any watched transactions are part of the block, confirming them if so. | ||
| /// | ||
| /// # Panics | ||
| /// | ||
| /// Panics if the new block's height is not exactly one more than the last processed height. | ||
| pub(crate) fn process_block(&mut self, block: &Block, height: u64) { |
There was a problem hiding this comment.
Nevertheless, it might be worth looking at those changes after merging. I know you wanted to change how we monitor the blockchain anyway, so maybe only 1010f95 is relevant.
There was a problem hiding this comment.
Yeah I think better to take that later, but thanks for the pointers!
dlc-manager/src/channel_updater.rs
Outdated
Comment on lines
1734
to
1735
| counter_buffer_adaptor_signature: *accept_buffer_adaptor_signature, | ||
| own_buffer_adaptor_signature: *offer_buffer_adaptor_signature, |
There was a problem hiding this comment.
We fixed this bug in our branch: 0191dc4.
Tibo-lg
force-pushed
the
chore/port-back-lightning-changes
branch
from
a280669 to
4ff8528
Compare
Tibo-lg
force-pushed
the
chore/port-back-lightning-changes
branch
from
4ff8528 to
a88ea41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back many fixes and changes that were made for the lightning experimental branch to master.