Minor fix to solve error when compiling with Clang in Mac OS 10.8 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include clang and mac os in list of tested systems
ghost
assigned
alexvonduar
pushed a commit
to alexvonduar/akaze
that referenced
this pull request
Jan 29, 2018
This bug is introduced by Support_CentOS7 and caused the issue pablofdezalc#1 and pablofdezalc#2. Lx and Ly must be passed by value, instead of by reference, because Lx and Ly are local variables and the lifetime of kcontrast_ async task extends beyond the scope of Compute_Base_Evolution_Level(). Although the heap memory is supposed to be pinned down by AKAZEFeatures::lx_ and ly_, its reference count seems to go wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.