Upright MLDB computation seems inconsistent with regular #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the computation of upright MLDB descriptors, it looks like the idea is to assume the angle is zero. In the computation of `rrx` and `rry` in the rotated MLDB, though, this would imply `rrx=ry`. This may not affect performance, but it would be nice to understand what is going on here. If the intention is for Upright to be the same as the other one with a zero angle, this looks like a bug either here or in the regular MLDB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the computation of upright MLDB descriptors, it looks like the idea is to assume the angle is zero. In the computation of
rrxandrryin the rotated MLDB, though, this would implyrrx=ry. This may not affect performance, but it would be nice to understand what is going on here. If the intention is for Upright to be the same as the other one with a zero angle, this looks like a bug either here or in the regular MLDB.