-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: ly-git
#6972
base: master
Are you sure you want to change the base?
add: ly-git
#6972
Conversation
packages/ly-git/config_dir-fix.patch
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who made this patch file, and also can this be put outside the repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote the patch after investigating a problem with how it creates the configuration files which occurs when changing the install destination folder.
I'm not sure where else to put this patch file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that this is a git package and you have a build patch, which while it may work right now, could fail in the future when upstream decides to change something in build.zig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I'll instead submit a pacscript for the stable release in the meantime while I try to get the patch merged upstream for now.
Sorry I meant don't enable ly.service in post_install either. Tell the user to do it, but don't do it automatically. |
Progress