Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: ly-git #6972

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

add: ly-git #6972

wants to merge 7 commits into from

Conversation

villamorrd
Copy link
Contributor

Progress

  • Edit packagelist
  • Add initial pacscript
  • Contact devs
  • Add maintainer to pacscript

@github-actions github-actions bot added the Package Add Use this to request a package to be added label Jan 31, 2025
@villamorrd villamorrd marked this pull request as draft January 31, 2025 16:24
@villamorrd villamorrd marked this pull request as ready for review January 31, 2025 18:31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who made this patch file, and also can this be put outside the repository?

Copy link
Contributor Author

@villamorrd villamorrd Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote the patch after investigating a problem with how it creates the configuration files which occurs when changing the install destination folder.

I'm not sure where else to put this patch file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that this is a git package and you have a build patch, which while it may work right now, could fail in the future when upstream decides to change something in build.zig.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I'll instead submit a pacscript for the stable release in the meantime while I try to get the patch merged upstream for now.

packages/ly-git/ly-git.pacscript Outdated Show resolved Hide resolved
@Elsie19
Copy link
Member

Elsie19 commented Jan 31, 2025

Sorry I meant don't enable ly.service in post_install either. Tell the user to do it, but don't do it automatically.

@villamorrd villamorrd marked this pull request as draft January 31, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package Add Use this to request a package to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants