fix(hal-browser): upgrading HAL browser dependencies for vulnerability fix #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Sorry for the slow response. I've been on a break. Thank you so much for this! I'll try and get it out ASAP. |
|
This is great, thank you. |
|
I've merged this, but then in further testing, I came across tiny bug with the embedded resources. old screen:
new screen: It should collapse the embedded resources by default rather than expanding them. I'll get this out, as I don't think it's a show stopper, but I'd very much appreciate if you'd be able to identify the fix that that as I'm under the PUMP at the moment! |
|
Hi @bethesque, We will raise another PR for above bug fix within a week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is about using recent version of javascript library in HAL browser so that known vulnerabilities reported at pact-foundation/pact-broker-docker#69 can be removed from the component.
Other developer who has contributed to fix are: