Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme): align text styles used in app with Figma design specifications #37

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

esmaeil-ahmadipour
Copy link
Collaborator

No description provided.

@esmaeil-ahmadipour
Copy link
Collaborator Author

esmaeil-ahmadipour commented Dec 6, 2024

Pouria , please check some errors on ci and fix them. after resolve the problems , then send review request again.


@PouriaMoradi021

@PouriaMoradi021
Copy link

everything is done!

@esmaeil-ahmadipour

@phoenixit99
Copy link

phoenixit99 commented Dec 6, 2024

everything is done!

@esmaeil-ahmadipour

The PR is Draft. Please change it to "Ready for review" @PouriaMoradi021

@esmaeil-ahmadipour
Copy link
Collaborator Author

@phoenixit99 , @PouriaMoradi021

Please note that the final commit must be made after the latest changes and right before the merge. This commit should include the changelog updates and the app version upgrade. We need to either have a discussion to align on this or follow the established format used in the changelog file so far. The commit message should also follow a consistent pattern.

update: update `CHANGELOG.md` & `pubspec.yaml` files

@esmaeil-ahmadipour esmaeil-ahmadipour marked this pull request as ready for review December 6, 2024 18:14
Copy link

@phoenixit99 phoenixit99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

@esmaeil-ahmadipour
Copy link
Collaborator Author

please use onSurfacePallet in text styles . according some part of material spec in this link.

Surface – Default color for backgrounds

On surface – Text and icons against any surface color

Examining Figma, we conclude that there is no consistent color for texts in light and dark mode, and there is a noticeable irregularity. Due to the need to temporarily fix this issue, follow the solution below :

Light Text Color : #242424

Dark Text Color #FFFFFF

Please add this color for color palettes (surface and non-surface) - if they are not available -


@PouriaMoradi021

@esmaeil-ahmadipour esmaeil-ahmadipour marked this pull request as draft December 7, 2024 19:05
@esmaeil-ahmadipour esmaeil-ahmadipour added hold On hold, awaiting further action refactor Update/Change an exist feature and removed enhancement New feature or request labels Dec 12, 2024
@esmaeil-ahmadipour esmaeil-ahmadipour marked this pull request as ready for review December 13, 2024 13:18
@esmaeil-ahmadipour esmaeil-ahmadipour merged commit 619a160 into develop Dec 13, 2024
2 checks passed
@esmaeil-ahmadipour esmaeil-ahmadipour added the review done Review done and ready to merge label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold On hold, awaiting further action refactor Update/Change an exist feature review done Review done and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor and align text styles in themes with Figma design specifications
3 participants