-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(theme): align text styles used in app with Figma
design specifications
#37
refactor(theme): align text styles used in app with Figma
design specifications
#37
Conversation
Pouria , please check some errors on |
everything is done! |
The PR is Draft. Please change it to "Ready for review" @PouriaMoradi021 |
@phoenixit99 , @PouriaMoradi021 Please note that the final commit must be made after the latest changes and right before the merge. This commit should include the changelog updates and the app version upgrade. We need to either have a discussion to align on this or follow the established format used in the changelog file so far. The commit message should also follow a consistent pattern.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done
please use
Examining Figma, we conclude that there is no consistent color for texts in light and dark mode, and there is a noticeable irregularity. Due to the need to temporarily fix this issue, follow the solution below : Light Text Color : Dark Text Color Please add this color for color palettes (surface and non-surface) - if they are not available - |
…into refactor/text-styles-theme-figma-specs
No description provided.