test: protect tests from bad random height (#763)

Co-authored-by: Amir Babazadeh <[email protected]>
pactus-project · Oct 20, 2023 · 1fc2f15 · 1fc2f15
1 parent 11299c6
commit 1fc2f15
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/execution/executor/transfer_test.go b/execution/executor/transfer_test.go
@@ -48,7 +48,7 @@ func (td *testData) checkTotalCoin(t *testing.T, fee int64) {
 }
 
 func (td *testData) randomAmountAndFee(min int64, max int64) (int64, int64) {
-	amt := td.RandInt64NonZero(max)
+	amt := td.RandInt64NonZero(max - 1) // To make sure amt+fee is less than max
 	for amt < min {
 		amt = td.RandInt64NonZero(max)
 	}

diff --git a/util/testsuite/testsuite.go b/util/testsuite/testsuite.go
@@ -133,9 +133,9 @@ func (ts *TestSuite) RandIntNonZero(max int) int {
 	return ts.RandInt(max) + 1
 }
 
-// RandHeight returns a random number between [1, 1,000,000] for block height.
+// RandHeight returns a random number between [1000, 1000000] for block height.
 func (ts *TestSuite) RandHeight() uint32 {
-	return ts.RandUint32NonZero(1e6)
+	return ts.RandUint32NonZero(1e6-1000) + 1000
 }
 
 // RandRound returns a random number between [0, 10) for block round.