-
Notifications
You must be signed in to change notification settings - Fork 145
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(http): add basic auth middleware for http server (#1372)
- Loading branch information
Showing
6 changed files
with
106 additions
and
132 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package http | ||
|
|
||
| import ( | ||
| "net/http" | ||
|
|
||
| "github.com/pactus-project/pactus/www/grpc/basicauth" | ||
| "google.golang.org/grpc/metadata" | ||
| ) | ||
|
|
||
| func basicAuth(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| user, password, ok := r.BasicAuth() | ||
| if !ok { | ||
| w.Header().Set("WWW-Authenticate", `Basic realm="restricted", charset="UTF-8"`) | ||
| http.Error(w, "unauthorized", http.StatusUnauthorized) | ||
|
|
||
| return | ||
| } | ||
|
|
||
| ba := basicauth.New(user, password) | ||
| tokens, _ := ba.GetRequestMetadata(r.Context()) | ||
| md := metadata.New(tokens) | ||
|
|
||
| r = r.WithContext(metadata.NewOutgoingContext(r.Context(), md)) | ||
|
|
||
| next.ServeHTTP(w, r) | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package http | ||
|
|
||
| import ( | ||
| "encoding/base64" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "google.golang.org/grpc/metadata" | ||
| ) | ||
|
|
||
| func TestBasicAuthMiddleware(t *testing.T) { | ||
| handler := basicAuth(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { | ||
| w.WriteHeader(http.StatusOK) | ||
| _, err := w.Write([]byte("authorized")) | ||
| assert.NoError(t, err) | ||
| })) | ||
|
|
||
| t.Run("NoAuth", func(t *testing.T) { | ||
| req := httptest.NewRequest(http.MethodGet, "/", http.NoBody) | ||
| rr := httptest.NewRecorder() | ||
|
|
||
| handler.ServeHTTP(rr, req) | ||
|
|
||
| assert.Equal(t, http.StatusUnauthorized, rr.Code) | ||
| assert.Equal(t, `Basic realm="restricted", charset="UTF-8"`, rr.Header().Get("WWW-Authenticate")) | ||
| }) | ||
|
|
||
| t.Run("WithAuth", func(t *testing.T) { | ||
| req := httptest.NewRequest(http.MethodGet, "/", http.NoBody) | ||
| req.SetBasicAuth("username", "password") | ||
| rr := httptest.NewRecorder() | ||
|
|
||
| handler.ServeHTTP(rr, req) | ||
|
|
||
| assert.Equal(t, http.StatusOK, rr.Code) | ||
| assert.Equal(t, "authorized", rr.Body.String()) | ||
| }) | ||
|
|
||
| t.Run("CheckMetadata", func(t *testing.T) { | ||
| req := httptest.NewRequest(http.MethodGet, "/", http.NoBody) | ||
| req.SetBasicAuth("username", "password") | ||
| rr := httptest.NewRecorder() | ||
|
|
||
| checkMetadataHandler := basicAuth(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| md, ok := metadata.FromOutgoingContext(r.Context()) | ||
| if !ok { | ||
| t.Errorf("No metadata in context") | ||
| } | ||
|
|
||
| auth := md["authorization"][0] | ||
|
|
||
| const prefix = "Basic " | ||
| c, err := base64.StdEncoding.DecodeString(auth[len(prefix):]) | ||
| assert.NoError(t, err) | ||
| cs := string(c) | ||
| username, password, ok := strings.Cut(cs, ":") | ||
| assert.True(t, ok) | ||
|
|
||
| assert.Equal(t, "username", username) | ||
| assert.Equal(t, "password", password) | ||
|
|
||
| w.WriteHeader(http.StatusOK) | ||
| })) | ||
|
|
||
| checkMetadataHandler.ServeHTTP(rr, req) | ||
|
|
||
| assert.Equal(t, http.StatusOK, rr.Code) | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters