fix: add broken test

pactus-project · Dec 21, 2024 · b1a212f · b1a212f
1 parent 5e3a5c8
commit b1a212f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 19 deletions.
diff --git a/state/mock.go b/state/mock.go
@@ -1,7 +1,6 @@
 package state
 
 import (
-	"fmt"
 	"sync"
 	"time"
 
@@ -104,9 +103,6 @@ func (m *MockState) CommitBlock(blk *block.Block, cert *certificate.BlockCertifi
 	m.lk.Lock()
 	defer m.lk.Unlock()
 
-	if cert.Height() != m.TestStore.LastHeight+1 {
-		return fmt.Errorf("invalid height")
-	}
 	m.TestStore.SaveBlock(blk, cert)
 
 	return nil

diff --git a/sync/firewall/firewall.go b/sync/firewall/firewall.go
@@ -244,7 +244,7 @@ func (f *Firewall) isExpiredMessage(msgData []byte) bool {
 
 	// The message is expired, or the consensus height is behind the network's current height.
 	// In either case, the message is dropped and won't be propagated.
-	if consensusHeight < f.state.LastBlockHeight()-1 {
+	if f.state.LastBlockHeight() > 0 && consensusHeight < f.state.LastBlockHeight()-1 {
 		f.logger.Warn("firewall: expired message", "message height", consensusHeight, "our height", f.state.LastBlockHeight())
 
 		return true

diff --git a/sync/firewall/firewall_test.go b/sync/firewall/firewall_test.go
@@ -438,20 +438,15 @@ func TestAllowBlockRequest(t *testing.T) {
 
 	td := setup(t, conf)
 
-	td.state.CommitTestBlocks(10)
+	testBlk, testCert := td.GenerateTestBlock(2_900_001)
+	td.state.CommitBlock(testBlk, testCert)
 
 	t.Run("expired message", func(t *testing.T) {
 		msg := makeTestGossipMessage(td.state.LastBlockHeight() - 2)
 
 		assert.Equal(t, network.Drop, td.firewall.AllowBlockRequest(msg))
 	})
 
-	t.Run("expired message", func(t *testing.T) {
-		msg := makeTestGossipMessage(td.state.LastBlockHeight() + 2)
-
-		assert.Equal(t, network.Drop, td.firewall.AllowBlockRequest(msg))
-	})
-
 	t.Run("rate limit exceeded", func(t *testing.T) {
 		msg := makeTestGossipMessage(td.state.LastBlockHeight())
 
@@ -480,20 +475,15 @@ func TestAllowConsensusRequest(t *testing.T) {
 
 	td := setup(t, conf)
 
-	td.state.CommitTestBlocks(10)
+	testBlk, testCert := td.GenerateTestBlock(2_900_001)
+	td.state.CommitBlock(testBlk, testCert)
 
 	t.Run("expired message", func(t *testing.T) {
 		msg := makeTestGossipMessage(td.state.LastBlockHeight() - 2)
 
 		assert.Equal(t, network.Drop, td.firewall.AllowConsensusRequest(msg))
 	})
 
-	t.Run("expired message", func(t *testing.T) {
-		msg := makeTestGossipMessage(td.state.LastBlockHeight() + 2)
-
-		assert.Equal(t, network.Drop, td.firewall.AllowConsensusRequest(msg))
-	})
-
 	t.Run("rate limit exceeded", func(t *testing.T) {
 		msg := makeTestGossipMessage(td.state.LastBlockHeight())