-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grpc): adding is pruned and pruning height in blockchain info API #1420
Conversation
@Ja7ad Hi, change requests fixed, please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be compatible with Bitcoin RPC, let's add these information to the blockchain-info. Check here: https://developer.bitcoin.org/reference/rpc/getblockchaininfo.html
@b00f Also, why we need to be compatible with Bitcoin RPC? We are not a fork or L2. Also no bitcoin application uses Pactus. so whats the reason to be compatible? |
I think pruning information fits better in BlockchainInfo rather than NodeInfo. Regarding Bitcoin compatibility, many developers are familiar with Bitcoin, so we should create something that looks familiar and is better organized. |
@b00f Blokchain info contains the chain info which is shared, node info contains the info about one node which is not shared between all nodes. |
|
Related issue