refactor(cmd): get first account address from wallet as reward address #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1594 +/- ##
==========================================
+ Coverage 75.07% 76.25% +1.18%
==========================================
Files 234 236 +2
Lines 12156 18243 +6087
==========================================
+ Hits 9126 13912 +4786
- Misses 2582 3874 +1292
- Partials 448 457 +9 |
Ja7ad
reviewed
Nov 11, 2024
akbariandev
reviewed
Nov 11, 2024
Ja7ad
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a change in behavior for obtaining the reward address.
If the reward address is not specified in the config, it attempts to retrieve it from the wallet.
The first Ed25519 account address is considered as the reward address, and if not available, the first BLS account address is used.