Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus): refcator strong termination for change-proposer phase #1643

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Dec 10, 2024

Description

Send decided vote for past round

@Ja7ad Ja7ad requested a review from b00f December 10, 2024 06:34
@b00f b00f changed the title fix(consensus): send decided vote for past round fix(consensus): refcator strong termination for change-proposer phase Dec 18, 2024
refactor(consensus): refcator strong termination for change-proposer phase
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.18%. Comparing base (86a8ba9) to head (9c25694).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
+ Coverage   75.07%   76.18%   +1.11%     
==========================================
  Files         234      236       +2     
  Lines       12156    18279    +6123     
==========================================
+ Hits         9126    13926    +4800     
- Misses       2582     3895    +1313     
- Partials      448      458      +10     

consensus/consensus_test.go Outdated Show resolved Hide resolved
@b00f b00f merged commit 721e5f4 into pactus-project:main Dec 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants