Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zeromq): add ZMQ Publishers to NodeInfo API #1674

Merged
merged 7 commits into from
Jan 19, 2025

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Jan 19, 2025

Description

Add ZMQ Publisher Information to NodeInfo API

Related issue(s)

@Ja7ad Ja7ad requested a review from b00f January 19, 2025 12:28
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.56%. Comparing base (86a8ba9) to head (480919d).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
+ Coverage   75.07%   76.56%   +1.49%     
==========================================
  Files         234      241       +7     
  Lines       12156    18553    +6397     
==========================================
+ Hits         9126    14206    +5080     
- Misses       2582     3887    +1305     
- Partials      448      460      +12     

www/grpc/proto/network.proto Outdated Show resolved Hide resolved
@b00f b00f changed the title feat(zeromq): add ZMQ Publisher Information to NodeInfo API feat(zeromq): add ZMQ Publishers to NodeInfo API Jan 19, 2025
www/grpc/proto/network.proto Show resolved Hide resolved
www/http/network_test.go Outdated Show resolved Hide resolved
@b00f b00f merged commit 2edab04 into pactus-project:main Jan 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ZMQ Publisher Information to NodeInfo API
2 participants