-
Notifications
You must be signed in to change notification settings - Fork 20
Add support for Bitbucket 4.0.0 #16
base: master
Are you sure you want to change the base?
Conversation
From Stash's documentation, the logs are placed under a _log_ directory and not in _logs_ https://confluence.atlassian.com/stash/stash-debug-logging-282988756.html
* commit '0fc338230426d22775a6750d33520d81430ab05a': Implement user project exclusion
Actually. Scratch that. It only compiles, but doesn't work yet. The soy templates are not rendering. Can someone help fix that? (I have no experience with Atlassian plugin development) |
I (no longer at palantir) will see what I can do if I get a chance. Typically Palantir doesn't do major version bumps of atlassian stuff until they are on X.1 or X.2, so it could take them a while to get to it. |
@terabyte Sounds good. Thanks. |
Ok, everything is in except for the bitbucket 4.0.0 commit. I am taking a look now. |
Will https://github.com/terabyte/stash-codesearch-plugin become the new official repo? |
I don't know the answer to those questions yet. If Palantir is willing to support this thing and keep it up to date I see no reason to fork, but if there isn't resources to do that, better that someone does it. Thanks to the wonder of DVCS, it suffices to say right now that there is no "official" repo, just the palantir version and the terabyte version. Whether or not I upload my versions to the marketplace will again depend upon palantir's willingness to do so. I worry if I go full hog and fork needlessly I'm potentially just making more work for myself, because they could ask me to change the plugin key and logos (maybe? unsure about the legalities there). |
Almost have it working, but not quite: https://github.com/terabyte/stash-codesearch-plugin/tree/feature/bitbucket-4.0 The search works, but the servlets aren't rendering quite right yet. |
@terabyte I just tried https://github.com/terabyte/stash-codesearch-plugin/releases/tag/2.0.0 and it works for me. Thanks for helping out. |
awesome! no problemo, glad to help out! |
This PR adds support for Bitbucket Server 4.0.0
Various changes from @terabyte and @gliptak are also merged in.