Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Add support for Bitbucket 4.0.0 #16

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add support for Bitbucket 4.0.0 #16

wants to merge 7 commits into from

Conversation

mithun
Copy link

@mithun mithun commented Oct 15, 2015

This PR adds support for Bitbucket Server 4.0.0

Various changes from @terabyte and @gliptak are also merged in.

@mithun
Copy link
Author

mithun commented Oct 15, 2015

Actually. Scratch that. It only compiles, but doesn't work yet. The soy templates are not rendering. Can someone help fix that? (I have no experience with Atlassian plugin development)

@terabyte
Copy link
Contributor

I (no longer at palantir) will see what I can do if I get a chance. Typically Palantir doesn't do major version bumps of atlassian stuff until they are on X.1 or X.2, so it could take them a while to get to it.

@terabyte
Copy link
Contributor

@mithun @gliptak Thanks very much for your changes so far - I am testing every change before the bitbucket change in a separate branch which I will push to terabyte/stash-code-search master once I am satisfied. Then I'll take a look at the bitbucket changes and see what I can do there.

@mithun
Copy link
Author

mithun commented Oct 15, 2015

@terabyte Sounds good. Thanks.

@terabyte
Copy link
Contributor

Ok, everything is in except for the bitbucket 4.0.0 commit. I am taking a look now.

@gliptak
Copy link

gliptak commented Oct 15, 2015

Will https://github.com/terabyte/stash-codesearch-plugin become the new official repo?
@terabyte Are you planning to publish to Atlassian plugin repo (preferably both 3.x and 4.x versions)?
Thanks

@terabyte
Copy link
Contributor

I don't know the answer to those questions yet. If Palantir is willing to support this thing and keep it up to date I see no reason to fork, but if there isn't resources to do that, better that someone does it.

Thanks to the wonder of DVCS, it suffices to say right now that there is no "official" repo, just the palantir version and the terabyte version. Whether or not I upload my versions to the marketplace will again depend upon palantir's willingness to do so. I worry if I go full hog and fork needlessly I'm potentially just making more work for myself, because they could ask me to change the plugin key and logos (maybe? unsure about the legalities there).

@terabyte
Copy link
Contributor

Almost have it working, but not quite: https://github.com/terabyte/stash-codesearch-plugin/tree/feature/bitbucket-4.0

The search works, but the servlets aren't rendering quite right yet.

@mithun
Copy link
Author

mithun commented Oct 23, 2015

@terabyte I just tried https://github.com/terabyte/stash-codesearch-plugin/releases/tag/2.0.0 and it works for me. Thanks for helping out.

@terabyte
Copy link
Contributor

awesome! no problemo, glad to help out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants