Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to turn on off features and fix JSONB error for admin page #959

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

Jonathanlau92
Copy link
Contributor

Description

  1. Add settings to turn on/off features of Overture
  • Add jSON settings to check if feature is turn on or off (true or false)
  • Features includes: search_feature, kanban_board, dataroom, our_investor_or_startup, cap_table, performance_report, shared_file, resource_portal
  1. Fix JSONB error in administrate
  • Previously, saving JSON array turns the value in string. Added a model method to write/parse the value into JSON before saving into the database. This solution is a temporary workaround given by the gem owner, found in this issue: save field results in to_s version all the time codica2/administrate-field-jsonb#1
  • This workaround suffices while waiting for the gem owner to fix it
  • Added display for the JSON (mainly the settings and the products) - can finally add products through the admin page

Notion link: https://www.notion.so/Setting-to-turn-on-off-features-in-Overture-5f22cc7cf45c4b4bbd92295d9f820160

Remarks

  • NIL

Testing

  • Tested by turning on-off overture feature for a startup account
  • Tested that can edit json value in admin page
  • Run through every page of overture to see if its still working fine

@Jonathanlau92 Jonathanlau92 merged commit 2def3e3 into develop Mar 16, 2021
@Jonathanlau92 Jonathanlau92 deleted the enhance/add-settings-to-turn-on-off-features branch March 16, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant