-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement String Accumulations with nanoarrow #60667
base: main
Are you sure you want to change the base?
Conversation
2a3c754
to
f24c79f
Compare
ad47864
to
0cb78cb
Compare
1700cae
to
192dba6
Compare
This reverts commit 53fc8d9.
@@ -0,0 +1,9 @@ | |||
[wrap-file] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would use the meson WrapDB entry, but in this case there's an upstream bug in nanoarrow that prevents us from using the latest release (0.6.0). See also apache/arrow-nanoarrow#702
Whenever 0.7.0 gets released we can go back to using the Meson WrapDB entry, although I don't think there is any huge rush for that either
This is an addon to the great work that @rhshadrach is doing in #60633
Here is performance on this branch:
versus without nanoarrow:
While they all show some improvement, cummin / cummax don't show as much. I believe this has to do with the fact that the implementations still have to access the Python runtime within a tight loop to perform comparisons. If we cared to optimize further, we could look at utf8proc