Clean Snow Notebook using Pangeo #50
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -3,7 +3,10 @@ | |||
| { | |||
There was a problem hiding this comment.
@tinaok this is fixed in the latest push in this PR
There was a problem hiding this comment.
We should update your affiliation in the other notebooks
There was a problem hiding this comment.
@acocac could you please fix my name? It's Michele Claus, not Clous
There was a problem hiding this comment.
my new affiliation is: Provare LTD
|
@pl-marasco the PR is ready to review. fyi, I've restructured the notebook and corrected the headings of the sections. The data/ADO_DSC_ITH1_0025.csv file is missing. Please upload it to the data folder in this PR or a separate one. |
Fixed in the latest commit 6572f71 |
| @@ -3,7 +3,10 @@ | |||
| { | |||
There was a problem hiding this comment.
The explanation of stacstac could help here?
also possible other tool such ashttps://github.com/stac-utils/xpystac, odc-stac?
Reply via ReviewNB
There was a problem hiding this comment.
Indeed, maybe worth to mention the alternatives. Thanks Tina, I wasn't aware of xpystac! Here an interesting discussion comparing odc-stac and stackstac: opendatacube/odc-stac#54
| @@ -3,7 +3,10 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. snow = xr.where((ndsi > 0.42) & ~np.isnan(ndsi), 1, ndsi)
The original notebook https://github.com/EO-College/cubes-and-clouds/blob/main/lectures/3.1_data_processing/exercises/_alternatives/31_data_processing_stac.ipynb
use 0.4 instead of 0.42
Reply via ReviewNB
There was a problem hiding this comment.
If we want to replicate exactly the same result we have to set the same threshold, otherwise we can also keep it as is.
There was a problem hiding this comment.
@clausmichele Good point, I'm using the 0.42 values as is the threshold mentioned in the Sentinel-2 Level-2A ATBD. The ultimate goal was finding a citable source, but, if you have another one, we can use 0.40 .
BTW I didn't check the compatibility between the outcomes as my ultimate purpose it's on the methodology.
There was a problem hiding this comment.
I can set it to 0.42 on my side, I am anyway updating it.
|
@pl-marasco @acocac well done the notebook is really good! It also helped me to fix things on my side |
The PR focuses on fixing headings and proofreading of the snow notebook using Pangeo.