Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Scaling with Dask #51

Merged
merged 7 commits into from
Nov 3, 2023
Merged

Clean Scaling with Dask #51

merged 7 commits into from
Nov 3, 2023

Conversation

acocac
Copy link
Member

@acocac acocac commented Nov 2, 2023

The PR focuses on fixing headings and proofreading of the Scaling with Dask notebook.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@acocac
Copy link
Member Author

acocac commented Nov 2, 2023

@tinaok the Data section of the notebook is still incomplete.

In this episode, we will be using xxx

@acocac
Copy link
Member Author

acocac commented Nov 2, 2023

@tinaok I've completed my revision of the notebooks and fix some grammar/typos. I also found some minor bugs. Note the last cell return an error.

cluster.shutdown()

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[31], line 1
----> 1 cluster.shutdown()

AttributeError: 'NoneType' object has no attribute 'shutdown'

@acocac acocac marked this pull request as ready for review November 2, 2023 16:07
@acocac acocac requested a review from tinaok November 2, 2023 16:07
@@ -15,12 +15,13 @@
"source": [
Copy link
Collaborator

@pl-marasco pl-marasco Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change my affiliation to , Provare LTD (UK) ?


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed @pl-marasco

@tinaok
Copy link
Collaborator

tinaok commented Nov 3, 2023

@tinaok I've completed my revision of the notebooks and fix some grammar/typos. I also found some minor bugs. Note the last cell return an error.

cluster.shutdown()

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[31], line 1
----> 1 cluster.shutdown()

AttributeError: 'NoneType' object has no attribute 'shutdown'

I'll have a look after merging this. Probably it is due to which machine we use? (cluster with gateway or machine only with local cluster)

@tinaok tinaok merged commit 8e514b5 into main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants