Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LUT selectors #1461

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Update LUT selectors #1461

merged 4 commits into from
Jan 9, 2025

Conversation

arielkr256
Copy link
Contributor

Background

EKS LUT selector fields were not accurate

Changes

  • $.spec.clusterIP -> $.responseObject.spec.clusterIP

@arielkr256 arielkr256 marked this pull request as ready for review January 9, 2025 19:46
@arielkr256 arielkr256 requested a review from a team as a code owner January 9, 2025 19:46
@arielkr256 arielkr256 enabled auto-merge (squash) January 9, 2025 19:47
@ben-githubs
Copy link
Contributor

Looks like validate is failing because of 2 things:

  • All the mappings for Zeek logs: id.orig_h is an actual field name with a dot in it; we should change the LUT mapping to not be a JSON path spcifyier, and just be the raw string "id.orig_h"
  • The GCP.Audit Tor mapping: remove the $.requestMetadata.callerIP mapping; the path is wrong, and the correct path is already in the mappings earlier

It's weird that we only just started seeing this error; I'm going to see if something changed with the way validate works

@arielkr256 arielkr256 merged commit 147dc87 into develop Jan 9, 2025
8 checks passed
@arielkr256 arielkr256 deleted the lut-selector-update branch January 9, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-githubs ben-githubs ben-githubs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielkr256 @ben-githubs