Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Generated Indexes v2 #1472

Merged
merged 13 commits into from
Jan 31, 2025
Merged

Auto Generated Indexes v2 #1472

merged 13 commits into from
Jan 31, 2025

Conversation

mbellifa
Copy link
Collaborator

This is a non fork version of #1465, description copied below:

Background

Previously we generated the data for the Detection Coverage page manually. These changes aim to automate this generation as well as the markdown indexes in the /indexes/ folder.

Changes

  • Adds steps to the release workflow which generates a detection-coverage.json and markdown indexes when a release is cut, which is then written back to the repo.
  • Indexes now link to the YAML file rather than the associated Python code as they previously did

Testing

  • It was difficult to fully test this since my fork doesn't have access to the same secrets. I made a branch with a modified workflow that commented out the portions requiring secrets. For example, this run does not use the Panther Bot secret.
  • I'm not sure if this method of writing back to the repo will work with code signing, let me know if you'd like me to try a different method
  • Note that the workflow changes happen before the actual release is cut, so it may block the release process if it errors

@mbellifa mbellifa requested a review from a team as a code owner January 14, 2025 18:23
@arielkr256
Copy link
Contributor

@mbellifa this is awesome! Would it make sense to also include the rule descriptions in the indexes?

@mbellifa
Copy link
Collaborator Author

@arielkr256 Good point, I updated the PR to add descriptions. You can see what it looks like in my little test fork: https://github.com/mbellifa/panther-analysis-test/blob/auto-indexes-run-fix/indexes/alpha-index.md

@@ -4,14 +4,14 @@ on:
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbellifa after discussing with the team I think it would be better to run this in a separate GHA that runs on PRs to develop vs adding it to the release workflow. This will ensure develop stays in sync with main and let us test it more thoroughly prior to each release.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielkr256 Would a workflow that triggered on a push to develop work? I'm thinking of using a filter that only runs when .yml files are changed so it doesn't loop. My concern with PRs is I'm reading that they can have different behavior/permission issues when a PR is opened from a fork, and I can envision increased merge conflicts if the indexes are built within the PRs themselves.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think that sounds great!

@arielkr256 arielkr256 added documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code labels Jan 24, 2025
…cutting flow

* Updated Panther Bot username/email
* Sorted headings for standard rules so files remain stable if there are no changes
@mbellifa
Copy link
Collaborator Author

@arielkr256 @le4ker I've updated this to work as a separate flow that fires on push instead of hooking into the release flow. Let me know what you think.

@arielkr256 arielkr256 added this pull request to the merge queue Jan 31, 2025
Merged via the queue into develop with commit d15d842 Jan 31, 2025
@arielkr256 arielkr256 deleted the auto-generated-indexes branch January 31, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants