Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowflake Brute Force Tuning #1477

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Snowflake Brute Force Tuning #1477

merged 1 commit into from
Jan 17, 2025

Conversation

ben-githubs
Copy link
Contributor

Background

We've observed a high number of alerts caused by JWT validation issues from our automations rotating tokens, and this PR will fix that.

Changes

  • Failed logins due to JWT issues are now signals
  • Failed logins logs due to event overflow are ignored; these events are generated only when we've had a bunch of previous failed logins, so we will already have alerted if we start seeing these

Testing

  • Added new unit tests for both types of error message

@ben-githubs ben-githubs requested a review from a team as a code owner January 15, 2025 22:27
@arielkr256 arielkr256 enabled auto-merge (squash) January 17, 2025 17:17
arielkr256
arielkr256 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@arielkr256 arielkr256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arielkr256 arielkr256 merged commit 7362dd2 into develop Jan 17, 2025
8 checks passed
@arielkr256 arielkr256 deleted the THREAT-440/snowflake-brute-force-tuning branch January 17, 2025 17:22
@arielkr256 arielkr256 added the tuning detection tuning label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielkr256 arielkr256 arielkr256 approved these changes

Assignees
No one assigned
Labels
tuning detection tuning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-githubs @arielkr256