Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tuning] GitHub Actions Trust Policy #1492

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[Tuning] GitHub Actions Trust Policy #1492

merged 1 commit into from
Jan 24, 2025

Conversation

arielkr256
Copy link
Contributor

Background

This policy was causing false positives in our test environment.

Changes

  • Parse AssumeRolePolicyDocument into json if needed
  • Reworked logic to not generate false positives on non-github related resources

Testing

  • new unit tests

@arielkr256 arielkr256 requested a review from a team as a code owner January 24, 2025 17:30
@arielkr256 arielkr256 added the tuning detection tuning label Jan 24, 2025
@arielkr256 arielkr256 merged commit c81c33d into develop Jan 24, 2025
8 checks passed
@arielkr256 arielkr256 deleted the github-action-policy-tuning branch January 24, 2025 17:55
le4ker pushed a commit that referenced this pull request Jan 28, 2025
@arielkr256 @le4ker
[Tuning] GitHub Actions Trust Policy (#1492)
88d2c37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-githubs ben-githubs ben-githubs approved these changes

Assignees
No one assigned
Labels
tuning detection tuning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielkr256 @ben-githubs