Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrontEndTrivia API / Backend #139

Closed
wants to merge 3 commits into from

Conversation

urianchang
Copy link
Collaborator

@urianchang urianchang commented Oct 12, 2017

This PR will add the basic skeleton of an API/backend for the FrontEndTrivia web app. Once it's merged to master, separate tickets can be opened to flesh out what's needed for the API.

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fulfill a feature request. Scope out basic structure for API backend #138 to be exact.

  • What is the current behavior? (You can also link to an open issue here)
    Currently, there isn't a backend. The questions for the app are read from a dictionary.

  • What is the new behavior (if this is a feature change)?
    There will be a backend that holds user information, questions and answers, and anything else requested in the future.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    I wouldn't say the PR "breaks" anything, but users will need to have MongoDB and Nodemon installed. At least for version 0.

  • Other information:
    I'll try to be detailed and thorough in the README about what is needed to run the server.

@urianchang
Copy link
Collaborator Author

@papistan I finished creating the basic backend. Please let me know what you think.

@papistan
Copy link
Owner

@urianchang sorry for delay while I was traveling. Since I've not worked with express, Mongoose or MongoDB, I'm not much help in review. Though this is of strong interest of mine once I polish a few other things off my plate. In the meantime, and since the app is currently auto-deployed on heroku through the github master branch, I've created an 'api-development' branch. If you could create a new pr to this branch you can merge and farm out some other task through issues just working off of this branch. I've added you as a collaborator so you should have merge access. Once things are fleshed out enough we can discuss merging with master and deploying. Thanks again and let me know if this works for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants