Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1414: adds support for time_bucket() #1443

Closed
wants to merge 10 commits into from

Conversation

devanbenz
Copy link
Contributor

Signed-off-by: Devan [email protected]# Ticket(s) Closed

  • Closes #

What

Why

How

Tests

Copy link
Collaborator

@rebasedming rebasedming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Not sure if you're done with this PR yet, but you'll need to test that time_bucket queries when pushed down to DuckDB yield the same results as those not pushed down and fall back to your time_bucket UDF.

On another note, we're moving pg_lakehouse to its own repo and renaming to pg_analytics. I would recommend opening PRs to that repo, it will make our migration process easier. https://github.com/paradedb/pg_analytics

Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
@devanbenz
Copy link
Contributor Author

devanbenz commented Aug 2, 2024

Nice! Not sure if you're done with this PR yet, but you'll need to test that time_bucket queries when pushed down to DuckDB yield the same results as those not pushed down and fall back to your time_bucket UDF.

On another note, we're moving pg_lakehouse to its own repo and renaming to pg_analytics. I would recommend opening PRs to that repo, it will make our migration process easier. paradedb/pg_analytics

Ah yeah I'm not quite finished with this yet. Still working on tests! :) Sounds good I'll go ahead and re-open this there tomorrow/during the weekend.

@devanbenz
Copy link
Contributor Author

@rebasedming I'm assuming that this is not pushing down to duckdb per the query plan:
Screenshot 2024-08-01 at 9 45 29 PM

@rebasedming
Copy link
Collaborator

Nice! Not sure if you're done with this PR yet, but you'll need to test that time_bucket queries when pushed down to DuckDB yield the same results as those not pushed down and fall back to your time_bucket UDF.
On another note, we're moving pg_lakehouse to its own repo and renaming to pg_analytics. I would recommend opening PRs to that repo, it will make our migration process easier. paradedb/pg_analytics

Ah yeah I'm not quite finished with this yet. Still working on tests! :) Sounds good I'll go ahead and re-open this there tomorrow/during the weekend.

Not necessarily. EXPLAIN doesn't work well, there's a separate open issue for that too. Best way to see if it's being pushed down is adding break points in the executor hook.

@devanbenz
Copy link
Contributor Author

Opened in new repo: paradedb/pg_analytics#32 Closing this one!

@devanbenz devanbenz closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants