-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1414: adds support for time_bucket() #1443
Conversation
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Not sure if you're done with this PR yet, but you'll need to test that time_bucket
queries when pushed down to DuckDB yield the same results as those not pushed down and fall back to your time_bucket
UDF.
On another note, we're moving pg_lakehouse
to its own repo and renaming to pg_analytics
. I would recommend opening PRs to that repo, it will make our migration process easier. https://github.com/paradedb/pg_analytics
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
Ah yeah I'm not quite finished with this yet. Still working on tests! :) Sounds good I'll go ahead and re-open this there tomorrow/during the weekend. |
@rebasedming I'm assuming that this is not pushing down to duckdb per the query plan: |
Not necessarily. |
Signed-off-by: Devan <[email protected]>
Opened in new repo: paradedb/pg_analytics#32 Closing this one! |
Signed-off-by: Devan [email protected]# Ticket(s) Closed
What
Why
How
Tests