clippy linting

Signed-off-by: Devan <[email protected]>

src/duckdb/time_bucket.rs

@@ -32,10 +32,10 @@ impl Display for TimeBucketInput {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         match self {
             TimeBucketInput::Date(input) => {
-                write!(f, "{}::DATE", input.to_string())
+                write!(f, "{}::DATE", input)
             }
             TimeBucketInput::Timestamp(input) => {
-                write!(f, "{}", input.to_string())
+                write!(f, "{}", input)
             }
         }
     }
@@ -45,10 +45,10 @@ impl Display for TimeBucketOffset {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         match self {
             TimeBucketOffset::Date(input) => {
-                write!(f, "DATE {}", input.to_string())
+                write!(f, "DATE {}", input)
             }
             TimeBucketOffset::Interval(input) => {
-                write!(f, "INTERVAL {}", input.to_string())
+                write!(f, "INTERVAL {}", input)
             }
         }
     }

tests/fixtures/mod.rs

@@ -228,6 +228,7 @@ pub fn duckdb_conn() -> duckdb::Connection {
     duckdb::Connection::open_in_memory().unwrap()
 }
 
+#[allow(dead_code)]
 pub fn time_series_record_batch() -> Result<RecordBatch> {
     // Define the fields for each datatype
     let fields = vec![

tests/time_bucket.rs

@@ -26,6 +26,7 @@ use shared::fixtures::arrow::primitive_setup_fdw_local_file_listing;
 use shared::fixtures::tempfile::TempDir;
 use sqlx::PgConnection;
 use std::fs::File;
+use time::Date;
 
 #[rstest]
 async fn test_time_bucket(mut conn: PgConnection, tempdir: TempDir) -> Result<()> {
@@ -46,6 +47,7 @@ async fn test_time_bucket(mut conn: PgConnection, tempdir: TempDir) -> Result<()
     )
     .execute(&mut conn);
 
+    #[allow(clippy::single_match)]
     match "SELECT time_bucket(INTERVAL '2 DAY', timestamp::DATE) AS bucket, AVG(value) as avg_value FROM timeseries GROUP BY bucket ORDER BY bucket;".execute_result(&mut conn) {
         Ok(_) => {}
         Err(error) => {
@@ -56,6 +58,7 @@ async fn test_time_bucket(mut conn: PgConnection, tempdir: TempDir) -> Result<()
         }
     }
 
+    #[allow(clippy::single_match)]
     match "SELECT time_bucket(INTERVAL '2 DAY') AS bucket, AVG(value) as avg_value FROM timeseries GROUP BY bucket ORDER BY bucket;".execute_result(&mut conn) {
         Ok(_) => {
             panic!(
@@ -75,5 +78,10 @@ async fn test_time_bucket(mut conn: PgConnection, tempdir: TempDir) -> Result<()
 
     assert_eq!(10, data.len());
 
+    let data: Vec<(Date,)> = "SELECT time_bucket(INTERVAL '1 YEAR', timestamp::DATE) AS bucket, AVG(value) as avg_value FROM timeseries GROUP BY bucket ORDER BY bucket;"
+        .fetch_result(&mut conn).unwrap();
+
+    assert_eq!(1, data.len());
+
     Ok(())
 }