Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support DataType::List cast to json and jsonb #187

Merged
merged 4 commits into from
Jan 3, 2025
Merged

feat: support DataType::List cast to json and jsonb #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa00815
feat: support Datatype::List cast to json and jsonb
kysshsy Dec 25, 2024
a107b1d
feat: fix array type downcast
kysshsy Dec 29, 2024
c97511d
test: primitive list to json test
kysshsy Dec 29, 2024
035f247
test: add struct_list to json test
kysshsy Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions src/schema/cell.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,118 @@ where
}
}

pub trait GetListValue
where
Self: Array + AsArray,
{
fn get_list_value(&self, index: usize) -> Result<Option<datum::JsonB>> {
let downcast_array = self.as_list::<i32>();

if downcast_array.nulls().is_some() && downcast_array.is_null(index) {
return Ok(None);
}

match downcast_array.value_type() {
DataType::Boolean => {
let list_array: ArrayRef = Arc::new(downcast_array.clone());
let values = list_array
.get_primitive_list_value::<BooleanArray, Option<bool>>(index)?
.map_or(vec![], |arr| {
arr.into_iter()
.map(|opt| opt.map_or(Value::Null, Value::from))
.collect()
});
Ok(Some(datum::JsonB(Value::Array(values))))
}
DataType::Int8 => {
let list_array: ArrayRef = Arc::new(downcast_array.clone());
let values = list_array
.get_primitive_list_value::<Int8Array, Option<i8>>(index)?
.map_or(vec![], |arr| {
arr.into_iter()
.map(|opt| opt.map_or(Value::Null, |v| Value::Number(Number::from(v))))
.collect()
});
Ok(Some(datum::JsonB(Value::Array(values))))
}
DataType::Int16 => {
let list_array: ArrayRef = Arc::new(downcast_array.clone());
let values = list_array
.get_primitive_list_value::<Int16Array, Option<i16>>(index)?
.map_or(vec![], |arr| {
arr.into_iter()
.map(|opt| opt.map_or(Value::Null, |v| Value::Number(Number::from(v))))
.collect()
});
Ok(Some(datum::JsonB(Value::Array(values))))
}
DataType::Int32 => {
let list_array: ArrayRef = Arc::new(downcast_array.clone());
let values = list_array
.get_primitive_list_value::<Int32Array, Option<i32>>(index)?
.map_or(vec![], |arr| {
arr.into_iter()
.map(|opt| opt.map_or(Value::Null, |v| Value::Number(Number::from(v))))
.collect()
});
Ok(Some(datum::JsonB(Value::Array(values))))
}
DataType::Int64 => {
let list_array: ArrayRef = Arc::new(downcast_array.clone());
let values = list_array
.get_primitive_list_value::<Int64Array, Option<i64>>(index)?
.map_or(vec![], |arr| {
arr.into_iter()
.map(|opt| opt.map_or(Value::Null, |v| Value::Number(Number::from(v))))
.collect()
});
Ok(Some(datum::JsonB(Value::Array(values))))
}
DataType::Utf8 => {
let list_array: ArrayRef = Arc::new(downcast_array.clone());
let values = list_array
.get_string_list_value(index)?
.map_or(vec![], |arr| {
arr.into_iter()
.map(|opt| opt.map_or(Value::Null, Value::String))
.collect()
});
Ok(Some(datum::JsonB(Value::Array(values))))
}
DataType::LargeUtf8 => {
let list_array: ArrayRef = Arc::new(downcast_array.clone());
let mut values = vec![];
for i in 0..list_array.len() {
let string_value = list_array
.get_primitive_value::<LargeStringArray>(i)?
.map_or(Value::Null, |v| Value::String(v.to_string()));
values.push(string_value);
}
Ok(Some(datum::JsonB(Value::Array(values))))
}
DataType::Struct(_) => {
let list_array = downcast_array.value(index);
let mut values = vec![];
for i in 0..list_array.len() {
let struct_value = list_array.get_struct_value(i)?.map_or(Value::Null, |v| v.0);
values.push(struct_value);
}
Ok(Some(datum::JsonB(Value::Array(values))))
}
DataType::List(_) => {
let list_array = downcast_array.value(index);
let mut values = vec![];
for i in 0..list_array.len() {
let list_value = list_array.get_list_value(i)?.map_or(Value::Null, |v| v.0);
values.push(list_value);
}
Ok(Some(datum::JsonB(Value::Array(values))))
}
unsupported => bail!("List with {:?} types are not yet supported", unsupported),
}
}
}

pub trait GetDecimalValue
where
Self: Array + AsArray,
Expand Down Expand Up @@ -559,6 +671,7 @@ where
+ GetIntervalDayTimeValue
+ GetIntervalMonthDayNanoValue
+ GetIntervalYearMonthValue
+ GetListValue
+ GetPrimitiveValue
+ GetPrimitiveListValue
+ GetStringListValue
Expand Down Expand Up @@ -1040,6 +1153,13 @@ where
None => Ok(None),
}
}
DataType::List(_) => match self.get_list_value(index)? {
Some(value) => {
let json_value: serde_json::Value = serde_json::to_value(value)?;
Ok(Some(Cell::Json(datum::Json(json_value))))
}
None => Ok(None),
},
unsupported => Err(DataTypeError::DataTypeMismatch(
name.to_string(),
unsupported.clone(),
Expand Down Expand Up @@ -1068,6 +1188,10 @@ where
None => Ok(None),
}
}
DataType::List(_) => match self.get_list_value(index)? {
Some(value) => Ok(Some(Cell::JsonB(value))),
None => Ok(None),
},
unsupported => Err(DataTypeError::DataTypeMismatch(
name.to_string(),
unsupported.clone(),
Expand Down Expand Up @@ -1266,6 +1390,7 @@ impl GetDecimalValue for ArrayRef {}
impl GetIntervalDayTimeValue for ArrayRef {}
impl GetIntervalMonthDayNanoValue for ArrayRef {}
impl GetIntervalYearMonthValue for ArrayRef {}
impl GetListValue for ArrayRef {}
impl GetPrimitiveValue for ArrayRef {}
impl GetPrimitiveListValue for ArrayRef {}
impl GetStringListValue for ArrayRef {}
Expand Down
Loading