feat: Add OptionValidator trait for FDW options validation and Sanitize user mapping options #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
requested review from
rebasedming,
neilyio and
philippemnoel
as code owners
Weijun-H
commented
Aug 8, 2024
Weijun-H
commented
Aug 8, 2024
rebasedming
reviewed
Aug 10, 2024
|
This PR is currently blocked by #66, which is blocked by: paradedb/wrappers#12 |
Weijun-H
force-pushed
the
1135-Sanitize-user-mapping-options
branch
from
14d4b3e to
772cf06
Compare
rebasedming
approved these changes
Aug 26, 2024
philippemnoel
approved these changes
Aug 26, 2024
Weijun-H
force-pushed
the
1135-Sanitize-user-mapping-options
branch
from
180498c to
03d88fb
Compare
Weijun-H
force-pushed
the
1135-Sanitize-user-mapping-options
branch
from
03d88fb to
ac8a351
Compare
shamb0
pushed a commit
to shamb0/pg_analytics
that referenced
this pull request
Aug 29, 2024
…ze user mapping options (paradedb#37) * feat: Sanitize the user mapping options * fix: Correct the bucket name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Why
How
OptionValidatorvalidatorfunctionTests