Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add open db transaction graph in grafana dashboard #13611

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add open db transaction graph in grafana dashboard #13611

wants to merge 2 commits into from

Conversation

tonypony220
Copy link
Contributor

Closes #13599

@tonypony220 tonypony220 marked this pull request as ready for review January 1, 2025 19:51
Rjected
Rjected reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonypony220 do you mind adding a screenshot of the graph?

@tonypony220
Copy link
Contributor Author

tonypony220 commented Jan 8, 2025 •
edited
Loading

@Rjected, there is 0 diff, and only one read-write. so those are not visible and you supposed to click on it to see. so that, on small diff it would be not noticeable from the first glance
image

Rjected
Rjected reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonypony220 it's possible to set up an axis on the right for values like this, seems like it would be useful here

@tonypony220
Copy link
Contributor Author

tonypony220 commented Jan 8, 2025 •
edited
Loading

@Rjected wow, cool! like this sounds good? mb better to split RW and R on two distinct?
image

@Rjected
Copy link
Member

Rjected commented Jan 8, 2025

@Rjected wow, cool! like this sounds good? mb better to split RW and R on two distinct? image

yeah, maybe we should have one panel for each:

  • read transactions (diff, opened, closed),
  • read-write transactions (diff, opened, closed)

@tonypony220
Copy link
Contributor Author

now it looks like this
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected left review comments

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add open db transaction graph in grafana dashboard
2 participants
@tonypony220 @Rjected