fix(trie): update prefix set on the call to RevealedSparseTrie::update_rlp_node_level
#14108
+185
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-bug
shekhirin
force-pushed
the
alexey/sparse-trie-rlp-node-log-paths
branch
from
17bc2bc to
2278214
Compare
mattsse
reviewed
Jan 30, 2025
rkrasiuk
approved these changes
Jan 30, 2025
shekhirin
force-pushed
the
alexey/sparse-trie-rlp-node-log-paths
branch
from
f93c257 to
95dc36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were doing the
std::mem::takefor the whole prefix set on each call toRevealedSparseTrie::root, but not onRevealedSparseTrie::update_rlp_node_level.Effectively, this made
update_rlp_node_levelhave no effect on the subsequentrootcall, because it was still re-calculating the whole trie.This PR makes the
RevealedSparseTrie::update_rlp_node_levelupdate the prefix set, so that it includes only those paths that are above the specified level. Just doing thetakeis not correct there, because the nodes above the specified level still need re-calculation.On the screenshot, before 14:40 is
main, after is this branch.