Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth for NetworkConfigBuilder #14109

Merged
merged 2 commits into from
Jan 30, 2025
Merged

eth for NetworkConfigBuilder #14109

merged 2 commits into from
Jan 30, 2025

Conversation

int88
Copy link
Contributor

@int88 int88 commented Jan 30, 2025

@int88 int88 requested review from mattsse and Rjected as code owners January 30, 2025 14:53
@int88
Copy link
Contributor Author

int88 commented Jan 30, 2025

@mattsse if the modification method is correct, I would replace all NetworkConfigBuilder::<EthNetworkPrimitives>::... stuff.

mattsse
mattsse approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse
Copy link
Collaborator

mattsse commented Jan 30, 2025

pending smol clippy fix

@mattsse mattsse added the A-networking Related to networking in general label Jan 30, 2025
@mattsse mattsse added this pull request to the merge queue Jan 30, 2025
Merged via the queue into paradigmxyz:main with commit 6ab1528 Jan 30, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@int88 @mattsse