Only cache metadata if successfully gathered #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umanwizard
approved these changes
Sep 5, 2024
| @@ -98,7 +98,8 @@ var ( | |||
| // MetadataProvider implementations support adding metadata to a labels.Builder. | |||
| type MetadataProvider interface { | |||
| // AddMetadata adds metadata to the provided labels.Builder for the given PID. | |||
| AddMetadata(pid libpf.PID, lb *labels.Builder) | |||
| // It returns whether the metadata is save to be cached. | |||
There was a problem hiding this comment.
Suggested change
| // It returns whether the metadata is save to be cached. | |
| // It returns whether the metadata can be safely cached. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.