Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] add option to generate node keys #365

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

BulatSaif
Copy link
Contributor

@BulatSaif BulatSaif commented Jan 30, 2025

The chart already has the persistGeneratedNodeKey option to generate node keys. These keys are random and stored on disk. They are not known before deployment, so they cannot be used for testnet bootnode deployments.

Changes:

  1. Add an option to generate node keys within helm secrets.
  2. Replace --node-key $(cat /path/to/key) with --node-key-file /path/to/key. This is more secure, as the key is not exposed in the ps output. cat was previously used to fix the newline issue at the end of the file. Keys stored in Helm secrets do not have a trailing newline.

@BulatSaif BulatSaif self-assigned this Jan 30, 2025
@BulatSaif BulatSaif force-pushed the bs/nodekey-generator branch from b6dfbe8 to d0aa830 Compare January 30, 2025 14:18
@BulatSaif BulatSaif merged commit b3d7dcf into main Feb 6, 2025
3 checks passed
@BulatSaif BulatSaif deleted the bs/nodekey-generator branch February 6, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants