-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG FIX] overflow does not work well #596
base: master
Are you sure you want to change the base?
Conversation
Seems I found related issue: #592 |
Thanks for this! I tried this fix, but one issue with it is that, when there is a list of nodes too long to fit on a single page, the horizontal scrollbar is now no longer visible and instead you must scroll to the bottom of the (potentially very long list) to see that you can scroll left and right at all. Alas, I feel like we'd need something a bit more comprehensive to fix the problem fully (ie have a horizontal scrollbar visible without having to scroll to the bottom of the list of nodes, and also not have the naff looking UI we see) |
I did a partial fix here; not perfect but improves things a bit at least: |
Hey! You're very welcome to for sure! I think it might be tricker to do nicely though: I think the aim should be to have a visaible horizontal scrollbar (when there is horizontal scrolling possible) regardless of how many nodes are in the list. Otherwise, it may not be obvious to people that horizontal scrolling is possible. I merged #598 which means that at least you can scroll horizontally and see the data, though it's obviously quite ugly still and very much a band aid :) |
@jsdw thanks for update. I will take a look and play with merged solution at the next week (I guess at monday). And yeah, I'm thinking that the final solution will be complicated. |
Awesome! Let me know how you get on! It would be lovely to improve but isn't something I can dedicate much time to at the moment :) |
Hello,
Our project uses substrate-telemetry with little redesign of UI. We found a bug with overflow-y (details at the end of this message), seems a table with content can't work properly if elements are off the screen.
PR contains the fix of this behavior. Actually we already use this fix (https://telemetry.qfnetwork.xyz).
How it looks now: https://telemetry.polkadot.io/#/0x91b171bb158e2d3848fa23a9f1c25182fb8e20313b2c1eb49219da7a70ce90c3:
After applying overflow-y: auto: https://telemetry.qfnetwork.xyz/#/0x12a5bf29b1e9f00a603993cdef83ef344ffaf68ecf096d6c4d23a42676eeaff4