-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add info panel item panel
to load and display data on demand
#2622
Merged
+207
−42
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2614563
added changes
f75b108
fix lint
d029823
update
f9a39db
fix lint
aa72ede
added changes
c3950d1
undo panel width size changess
88e47b8
Merge branch 'alpha' into feature/2610
mtrezza 0b56305
Merge branch 'alpha' into feature/2610
mtrezza e20c365
Merge branch 'alpha' into feature/2610
mtrezza 6be9105
Merge branch 'alpha' into feature/2610
mtrezza c81bf1c
Merge branch 'alpha' into feature/2610
mtrezza 01d1bdb
fixed horizontal left margin
vardhan0604 6ed8fb9
Merge branch 'feature/2610' of https://github.com/vardhan0604/parse-d…
vardhan0604 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ export default class DataBrowser extends React.Component { | |
firstSelectedCell: null, | ||
selectedData: [], | ||
prevClassName: props.className, | ||
panelWidth: 300, | ||
panelWidth: 400, | ||
isResizing: false, | ||
maxWidth: window.innerWidth - 300, | ||
showAggregatedData: true, | ||
|
@@ -591,7 +591,7 @@ export default class DataBrowser extends React.Component { | |
<ResizableBox | ||
width={this.state.panelWidth} | ||
height={Infinity} | ||
minConstraints={[100, Infinity]} | ||
minConstraints={[400, Infinity]} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please revert if not required for this PR; the panel should be resizable to min. 100 px width. |
||
maxConstraints={[this.state.maxWidth, Infinity]} | ||
onResizeStart={this.handleResizeStart} // Handle start of resizing | ||
onResizeStop={this.handleResizeStop} // Handle end of resizing | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, both of them were unintentional changes, i will revert them back in next commit.