Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate from istanbul to nyc; add lint job to CI #225

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

vahidalizad
Copy link
Contributor

Summary

This pull request includes:

  1. Switch from Istanbul to NYC:

    • Replaced deprecated Istanbul with NYC for code coverage.
  2. Config Update & Windows Compatibility:

    • Moved test/config to config and added a default config to eliminate the need for setting environment variables on Windows, ensuring tests run smoothly across platforms.

Impact

  • The project now uses NYC for coverage reporting.
  • Tests run consistently on both Windows and Unix-based systems.

Copy link

parse-github-assistant bot commented Oct 19, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@vahidalizad
Copy link
Contributor Author

vahidalizad commented Oct 20, 2024

@mtrezza I suspect the CI error is due to running Codecov directly from ./node_modules/.bin/codecov. To resolve this, I propose migrating to utilize GitHub's Codecov Actions instead. Should I proceed with this update or would you prefer to handle it? If I update the CI actions and add the necessary workflow, would you then add the required token to the repository secrets, or would you rather create a separate PR to handle the entire migration yourself?

@mtrezza mtrezza changed the title test: Migrate from istanbul to nyc ci: Migrate from istanbul to nyc; add lint to CI Oct 21, 2024
@mtrezza mtrezza changed the title ci: Migrate from istanbul to nyc; add lint to CI ci: Migrate from istanbul to nyc; add lint job to CI Oct 21, 2024
@mtrezza mtrezza merged commit abad05e into parse-community:master Oct 21, 2024
7 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants