refactor: Upgrade ldapjs from 2.3.3 to 3.0.7 (#8947)

parse-community · Feb 26, 2024 · f5d6fc9 · f5d6fc9
1 parent 68b745a
commit f5d6fc9
Show file tree

Hide file tree

Showing 3 changed files with 200 additions and 44 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -41,7 +41,7 @@
     "intersect": "1.0.1",
     "jsonwebtoken": "9.0.0",
     "jwks-rsa": "3.1.0",
-    "ldapjs": "2.3.3",
+    "ldapjs": "3.0.7",
     "lodash": "4.17.21",
     "lru-cache": "10.1.0",
     "mime": "3.0.0",

diff --git a/src/Adapters/Auth/ldap.js b/src/Adapters/Auth/ldap.js
@@ -78,7 +78,7 @@ function searchForGroup(client, options, id, resolve, reject) {
       return reject(new Parse.Error(Parse.Error.INTERNAL_SERVER_ERROR, 'LDAP group search failed'));
     }
     res.on('searchEntry', entry => {
-      if (entry.object.cn === options.groupCn) {
+      if (entry.pojo.attributes.find(obj => obj.type === 'cn').values.includes(options.groupCn)) {
         found = true;
         client.unbind();
         client.destroy();