-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add file beforeFind triggers, file ACL, file cleanup, file references #8385
Draft
dblythy
wants to merge
17
commits into
parse-community:alpha
Choose a base branch
from
dblythy:create-file
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
feat: add file beforeFind triggers, file ACL, file cleanup, file references
feat: Add file beforeFind triggers, file ACL, file cleanup, file references
Jan 11, 2023
Thanks for opening this pull request!
|
There is still a bit to do in this PR - just looking for general feedback about the approach @parse-community/server-review |
…into create-file
…into create-file
Looking forward to something like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
This PR overhauls the
File
functionality of Parse Server by:Creating
_FileObject
class:This class allows created files to be referenced. Allows files to be created with ACLs, allows file deletion to be controlled by ACLs (currently any user can delete a file if they have the URL)
Creating
_FileSession
class:This class creates "presigned urls" for Parse Files. Creates a token that is amended to the File URL. This token is then used in the
beforeFind
trigger to determine authentication. Will need to work in with directAccess.Creating
_FileReference
class:This class tracks file references per objectId and class, allowing the server to determine whether a file is an orphan.
Introduces
ParseServer.cleanupFiles
Developers will need to manually create
_FileObject
's and_FileReference
's for existing deployments._FileReferences
continues to update when objects are accessed.Closes: #1023
Closes: #8241
Approach
TODOs before merging