-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add test support for external database adapter #8883
Conversation
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #8883 +/- ##
==========================================
- Coverage 94.13% 93.79% -0.35%
==========================================
Files 186 186
Lines 14687 14724 +37
==========================================
- Hits 13826 13810 -16
- Misses 861 914 +53 ☔ View full report in Codecov by Sentry. |
@ddrechse Since I guess we cannot easily add a test for this; do you have an example that shows that this works? |
I do This is an example config.json for the Oracle Storage Adapter running against Free23c locally
|
Could you test this out by using the branch of this PR in parse-community/parse-server-database-adapter-template#4? Looking at the CI there, it's using a Parse Server version tag when installing Parse Server, so it doesn't have the feature of this PR yet and the CI there actually runs with the MongoDB storage adapter, right? If you could change it to use the branch of this PR, then passing the env vars in the CI should run the CI with Oracle DB adapter, and once we see that works, we can merge this PR, does that make sense? |
Yes it does |
@dplewis this is still ongoing development, partly outside of this org. Once we know it all works, we will merge and publish a repo template that you can use for your SQL adapter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check the coverage? Not sure if it's possible to write a simple test for this, otherwise we merge as is.
…r into realDBAdapterLoader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; waiting for CI to pass...
Signed-off-by: Manuel <[email protected]>
🎉 This change has been released in version 7.1.0-alpha.7 |
🎉 This change has been released in version 7.1.0-beta.1 |
🎉 This change has been released in version 7.1.0 |
Pull Request
Issue
Closes: #8788
Approach
Add support to dynamically import an external database adapter to run tests.
Tasks
n/a