-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade ldapjs from 2.3.3 to 3.0.2 #8891
Conversation
Snyk has created this PR to upgrade ldapjs from 2.3.3 to 3.0.2. See this package in npm: https://www.npmjs.com/package/ldapjs See this project in Snyk: https://app.snyk.io/org/acinader/project/21343059-02d9-4182-87d7-718a44b181ef?utm_source=github&utm_medium=referral&page=upgrade-pr
Thanks for opening this pull request! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #8891 +/- ##
==========================================
- Coverage 94.20% 94.19% -0.01%
==========================================
Files 186 186
Lines 14797 14802 +5
==========================================
+ Hits 13939 13943 +4
- Misses 858 859 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a conflict again, after I've merged some of the open PRs. Could you please resolve them, so we can merge this? Thanks
@mtrezza i resolved conflicts but there some new tests that you wrote about |
Which tests are you referring to? They all seem to pass except for some flaky tests. |
@onurhanife This PR also contains quite a few code style changes. Not sure where they come from, but could you please make sure they are not included in the PR? The PR should only contain the changes that are necessary for the fix. |
@mtrezza My prettiers require config file option enabled, and I prefer using double quotes in my Prettier configurations. However, I'm not sure where these style changes are coming from. I also noticed that the .prettierrc file is not in JSON format, which might be why it's not working correctly. Is it intentionally like this, or I can fix it with this PR? |
The code style changes I see in this PR make sense, but they shouldn't be in this PR. If easily possible, could you revert them and only keep the necessary changes? I believe it's just 1 code line that is required, and the package upgrade. It may be easier to just create a new PR? |
It seems something went wrong here. I suggest to either revert all changes by just replacing the files, or open a new PR. |
Closing via #8947 |
@onurhanife Kindly see #8947; the PR was simple and required just 1 line of code, when removing the code style changes. |
@mtrezza I was aware that we could handle it this simply, I just hadn't had the chance to focus on this side yet, but I see that you've resolved the issue in my place. Thank you. |
Pull Request
Issue
Closes: #8592
Approach
#8623 cloned, merged to alpha and conflicts are fixed
Tasks