-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Switch from Yoga v2 to Apollo V4 merge #8893
feat: Switch from Yoga v2 to Apollo V4 merge #8893
Conversation
Signed-off-by: Antoine Cormouls <[email protected]>
Co-authored-by: Manuel <[email protected]> Signed-off-by: Antoine Cormouls <[email protected]>
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #8893 +/- ##
==========================================
+ Coverage 94.20% 94.22% +0.02%
==========================================
Files 186 186
Lines 14797 14842 +45
==========================================
+ Hits 13939 13985 +46
+ Misses 858 857 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you again resolve the conflicts please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains unrelated code style changes, please revert these. Are they applied automatically by your IDE, or is that our pre-commit hook?
@mtrezza Did you also solved the issue or was there a mistake? Seems like you refers to different PR |
Apologies, I mixed up the browser tabs. This PR is still open. |
@mtrezza Hi, the code style changes are coming from parse-server's pre-commit hook. |
Could you just disable the hook in your local repo please, to make this easier. |
Closing via #8959 |
Pull Request
Issue
Closes: #8728
Approach
#8727 cloned, merged into alpha and conflicts resolved
Tasks